D28745: Skip caching thumbnails on encrypted filesystems

[Marcin Gurtowski]

marcingu added inline comments.

INLINE COMMENTS

> dfaure wrote in thumbnail.cpp:776
> I agree with your second sentence. I never said otherwise. It will work, *if* indeed we are both right that st_dev would never be 0 when stat() succeeds.
> My suggestion is that we make sure our assumption is correct -- at least, that we are told if it ever happens to be incorrect, by adding assert(baseStat.st_dev != 0) after the first lstat succeeds, and assert(fileStat.st_dev != 0) after the second lstat succeeds.

How about I set it to -1 at start and check for that instead? I checked definitions and it looks like dev_st is unsigned, but it shouldn't be a problem.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure
Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200822/58e7fbff/attachment-0001.htm>