D26448: Add KRecentFilesMenu to replace KRecentFileAction

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  A unittest would be useful too, especially if we then refactor the loading to use KIO jobs.
  
  But after 6 months, let's land this and keep working on it. Are you interested in writing the unittest and/or porting to KIO jobs, or do you need some help?

INLINE COMMENTS

> krecentfilesmenu.cpp:45
> +        }
> +        const QFontMetrics fontMetrics = QFontMetrics(QFont());
> +

Can be simplified to

  const QFontMetrics fontMetrics(QFont());

But this uses the application font, not this widget's font. The right thing to do would be to pass a QWidget* and use w->fontMetrics() here.

BRANCH
  recentfilemenu

REVISION DETAIL
  https://phabricator.kde.org/D26448

To: nicolasfella, #frameworks, dfaure
Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200808/18e9b736/attachment.htm>