D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

Pino Toscano noreply at phabricator.kde.org
Thu Apr 30 17:05:21 BST 2020


pino added a comment.


  > The patch should not require existing users to adapt
  
  Yes, that's also what I wrote earlier.
  
  Also, your patch basically includes D29136 <https://phabricator.kde.org/D29136> in the case of no DESTINATION parameter specified, hence my suggestion is:
  
  - edit D29136 <https://phabricator.kde.org/D29136> to do the fallback using the same logic introduced here: this way marble is already fixed with no other changes, and ki18n_install will work also with KDE_INSTALL_DIRS_NO_DEPRECATED (e.g. for release-service packages)
  - have this to add the DESTINATION parameter, so packages can opt-in to use it if they can/want

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D29299

To: kossebau, ilic, heikobecker, #frameworks, aacid, ltoscano
Cc: pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200430/d479b375/attachment.html>


More information about the Kde-frameworks-devel mailing list