D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Thu Apr 30 15:59:57 BST 2020


kossebau created this revision.
kossebau added reviewers: ilic, heikobecker.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  a) LOCALE_INSTALL_DIR is a deprecated variable from KDEInstallDirs,
  
    which will not be set with KDE_INSTALL_DIRS_NO_DEPRECATED
  
  b) if using KI18n without KDEInstallDirs, but e.g. GnuInstallDirs or
  
    custom install dir variables, having to explicitly set LOCALE_INSTALL_DIR
    before calling KI18N_INSTALL() is not best DX. Best is to follow
    typical install command macros and have this as explicit argument
    by the name DESTINATION, instead of (KDE-specific) automagic

REPOSITORY
  R249 KI18n

BRANCH
  adddestinationargtoki18ninstall

REVISION DETAIL
  https://phabricator.kde.org/D29299

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: kossebau, ilic, heikobecker
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200430/dba5cdaf/attachment.html>


More information about the Kde-frameworks-devel mailing list