D29208: [NestedListHelper] Improve indentation code

Igor Poboiko noreply at phabricator.kde.org
Thu Apr 30 14:22:20 BST 2020


poboiko added inline comments.

INLINE COMMENTS

> dfaure wrote in nestedlisthelper.cpp:87
> So the last block cannot be unindented? How come?

That's the current block being checked, not the next one. I've just checked to be sure, last block can be unindented :)

TBH, I don't really know if it's even possible for the current block to be invalid (that would probably mean that `textCursor()` returned by `QTextEdit` is invalid?). 
I've just borrowed this particular check from the old code...

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29208

To: poboiko, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200430/b32a53c1/attachment.html>


More information about the Kde-frameworks-devel mailing list