D29101: KNewStuff: Fix file path and process call

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> installation.cpp:610
> +                QStringList args = KShell::splitArgs(command);
> +                int exitcode = QProcess::execute(args.takeFirst(), args);
>  

Get program in exclusive line

  auto program = args.takeFirst();
  int exitcode = QProcess::execute(program, args);

The problem is args is modified at argument pass time, then second parameter expect it is. That's not guaranteed you should expect compiler to do the right thing.

REPOSITORY
  R304 KNewStuff

BRANCH
  bugfix_uninstall (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29101

To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent, leinir
Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200428/0559ad24/attachment.html>