D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

[Aleix Pol Gonzalez]

apol added a comment.


  Code looks good overall, I'd say you'll get to polish the weird bits when developing the kwin side.
  
  In fact, this probably could be implemented within kwin considering what we discussed last week. We could remove the weirdness we have to keep its ABI.

INLINE COMMENTS

> keyboard_shortcuts_inhibit_interface.cpp:25
> +    Private(Display *display, SurfaceInterface *surface, SeatInterface *seat, KeyboardShortcutsInhibitorInterface* q)
> +        : zwp_keyboard_shortcuts_inhibitor_v1(*display, s_version) // TODO check we want to use display
> +        , q(q)

You'll want to connect it to the respective client here, it's not a global anymore.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29231

To: bport, zzag, davidedmundson, apol
Cc: crossi, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200427/de36cafc/attachment.html>