D29231: [WIP] Add keyboard_shortcuts_inhibit protocol

Cyril Rossi noreply at phabricator.kde.org
Mon Apr 27 16:37:10 BST 2020


crossi added inline comments.

INLINE COMMENTS

> keyboard_shortcuts_inhibit_interface.cpp:92
> +{
> +return d->m_surface;
> +}

indentation is missing

> keyboard_shortcuts_inhibit_interface.h:39
> +    void setActive(bool active);
> +    bool isActive();
> +private:

Should be const

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29231

To: bport, zzag, davidedmundson, apol
Cc: crossi, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200427/688907b6/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list