D29210: [NestedListHelper] Fix indentation of selection, add tests

David Faure noreply at phabricator.kde.org
Sun Apr 26 23:57:11 BST 2020


dfaure added inline comments.

INLINE COMMENTS

> nestedlisthelper.cpp:225
> +            if (delta > 0) {
> +                // No list, we're increasing indentation -> create a new one
> +                listFmt.setStyle(QTextListFormat::ListDisc);

should the opposite happen? delete the list when decreasing indentation?

Or is that what the blkFmt.setObjectIndex(-1); is about?
A comment there would be useful...

To me setObjectIndex(-1) sounds like it could kill any kind of embedded object there.... but I might be wrong.

REVISION DETAIL
  https://phabricator.kde.org/D29210

To: poboiko, #frameworks, dfaure, mlaurent
Cc: kde-frameworks-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200426/3899fc90/attachment.html>


More information about the Kde-frameworks-devel mailing list