D29207: [Indexers] Ignore name-based mimetype for initial indexing decisions

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The name based mime type is inaccurate, so it should not be used to
  decide if a file should be indexed. In case a specific extension should
  be skipped this can still be done accurately by the name based filters,
  e.g.  instead of "image/png" "*.png" can be used, or the whole directory
  can be excluded.
  
  This inaccuracy is also confusing for the user, as a file without
  extension will be added to the index, but adding an extension removes
  the file from the index. The file extension may also be ambiguous.
  
  This also matches the current list of excluded mime types, which are
  source files for various languages. These blow up the full text index
  and thus should be excluded (by default), but just adding the file names
  increases the index size only marginally.
  
  The 'inability' to find files is a recurring user complaint.
  
  Depends on D28932 <https://phabricator.kde.org/D28932>

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D29207

AFFECTED FILES
  src/file/extractor/app.cpp
  src/file/firstrunindexer.cpp
  src/file/modifiedfileindexer.cpp
  src/file/newfileindexer.cpp
  src/file/unindexedfileiterator.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200426/018e010f/attachment.html>