D29199: honor the extractMetaData flag

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> exiv2extractor.cpp:172
>  
> -    if (image->pixelHeight()) {
> -        result->add(Property::Height, image->pixelHeight());
> -    }
> +    if (result->inputFlags() & ExtractionResult::ExtractMetaData) {
>  

`if (!....) return`

> astippich wrote in taglibextractor.cpp:99
> true, that was still written with D25517 <https://phabricator.kde.org/D25517> and D25515 <https://phabricator.kde.org/D25515> in mind

Still trivially possible:

  if (savedProperties.isEmpty()) {
      return;
  }
  if (extractFulltext) {
      // extract lyrics
  }
  if (!extractMetadata) {
      return
  }

> bruns wrote in xmlextractor.cpp:103
> correct place for the flags check

skipped, `if (!....) { continue; }`

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D29199

To: astippich, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200426/c5a30eca/attachment.html>