D29199: honor the extractMetaData flag

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> office2007extractor.cpp:79
> +
> +    if (docPropsEntries.contains(QStringLiteral("core.xml")) && result->inputFlags() & ExtractionResult::ExtractMetaData) {
>          QDomDocument coreDoc(QStringLiteral("core"));

Long line

  bool extractMetaData = ...
  if (extractMetaData && docPropsEntries.contains(QStringLiteral("core.xml")) {

> office2007extractor.cpp:144
>  
> -    if (docPropsEntries.contains(QStringLiteral("app.xml"))) {
> +    if (docPropsEntries.contains(QStringLiteral("app.xml")) && result->inputFlags() & ExtractionResult::ExtractMetaData) {
>          QDomDocument appDoc(QStringLiteral("app"));

Long line

  if (extractMetaData && docPropsEntries.contains(QStringLiteral("app.xml")) {

> office2007extractor.cpp:185
>      //
>      bool extractPlainText = (result->inputFlags() & ExtractionResult::ExtractPlainText);
>  

... like done here

> taglibextractor.cpp:99
>  {
>      if (savedProperties.isEmpty()) {
>          return;

when you add the flag check here, you can avoid the extra indentation below. Likewise in some other places.

> xmlextractor.cpp:103
>  
>                  if (e.localName() == QLatin1String("metadata")) {
>                      auto rdf = e.firstChildElement(QLatin1String("RDF"));

correct place for the flags check

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D29199

To: astippich, #baloo, bruns, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200426/fda1173e/attachment-0001.html>