D29170: Detect executables without +x permission in $PATH to improve error message

[David Faure]

dfaure added a comment.


  Meanwhile I sent an email to kde-frameworks-devel to get more input on the question.
  Supporting custom setups is a great feature for a powerful desktop environment.
  E.g. I deploy custom self-built apps for my users, so I use some of those custom KDE features. Not this particular one though because they like icons in the plasma panel which means the desktop file gets copied into a plasma-specific directory, unfortunately. But that means I at least do things like Exec[$e]=$HOME/.bin/foo so that it's the same for all users -- just to name one useful "custom setup" feature.

INLINE COMMENTS

> ahmadsamir wrote in desktopexecparser.cpp:465
> I think we should check for isExecutable() here too (this matches the behaviour of QStandardPaths::findExecutable()).

But if we do that, a non-executable file gets ignored here and we don't get the warning that this commit is all about.

It would all be much simpler [for this custom purpose] if findExecutable didn't check the executable bit ;-) Then we'd have one full path to check ourselves. Instead we have to duplicate the PATH lookup. I'd like to avoid having to also duplicate the current-dir-of-desktop-file lookup and the libexec lookup.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29170

To: dfaure, ahmadsamir
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200426/f51c39e4/attachment.html>