D28765: KSettings::Dialog: add support for KPluginInfos without a KService
Sune Vuorela
noreply at phabricator.kde.org
Fri Apr 24 19:07:57 BST 2020
svuorela accepted this revision.
svuorela added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kcmoduleinfo.cpp:73
> + lib = pluginInfo.libraryPath();
> + keywords = pluginInfo.property(QStringLiteral("Keywords")).toStringList();
> }
At a later point, I*m not sure what the purpose is for these members are - but that's probably for another changeset.
> kcmoduleinfo.h:131
> + * @warning This will be null if this KCModuleInfo was created from a KPluginInfo coming from KPluginMetaData.
> + * Prefer using pluginInfo() instead, which works for both kinds.
> + */
Can we mark it as deprecated?
REPOSITORY
R295 KCMUtils
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28765
To: dfaure, pino, broulik, mart, davidedmundson, ngraham, svuorela
Cc: svuorela, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200424/904472c4/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list