D28701: Add KPackage support to KNewStuffCore

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> kpackagejob.cpp:55
> +
> +class KPackageTask : public QObject, public QRunnable
> +{

is it worth encapsulating it in a runnable? the installation of a package is already in a separathe thread.

> kpackagejob.cpp:97
> +                    });
> +                    loop.exec();
> +                } else {

this would freeze a thread waiting another thread is done, while just using the job in an async wayshouldn't be much more heavy on the gui thread?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, broulik, bshah
Cc: alex, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200424/4d2a6a18/attachment.html>