D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Thu Apr 23 14:42:41 BST 2020


kossebau added inline comments.

INLINE COMMENTS

> kfontchooser.h:90
> +        ShowDifferences = 4,    ///< Display the font differences interfaces
> +        NoFixedCheckBox = 8     ///< Do not Show a checkbox to toggle showing only fixed fonts
>      };

I would add a final ",", so you do not need to touch the line if any further flags are added in the future. Improves git blame display per line :)

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontchooser-onlyfixed-display-flag (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29065

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200423/d5afb600/attachment.html>


More information about the Kde-frameworks-devel mailing list