D29065: [KFontChooser] Add a DisplayFlag to allow not showing fixedOnly checkbox

Ahmad Samir noreply at phabricator.kde.org
Thu Apr 23 12:45:55 BST 2020


ahmadsamir updated this revision to Diff 80988.
ahmadsamir added a comment.


  - Use a proper flag set, 0/1/2/4/8, from dfaure
  - When checking a flag is set use bitwise &, not bitwise ^, the latter would fail if another flag was set
  - As per dfaure's suggestion, when FixedFontsOnly is set, don't use the checkbox that toggles/filters fixed fonts
  - Add more use cases to the kfontchooserdialogtest app

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29065?vs=80792&id=80988

BRANCH
  l-kfontchooser-onlyfixed-display-flag (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29065

AFFECTED FILES
  src/kfontchooser.cpp
  src/kfontchooser.h
  tests/kfontchooserdialogtest.cpp

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200423/975e483f/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list