D29102: Prefer QIcon::pixmap(QWindow*, ...) overload
    Aleix Pol Gonzalez 
    noreply at phabricator.kde.org
       
    Wed Apr 22 17:01:48 BST 2020
    
    
  
apol created this revision.
apol added reviewers: Plasma, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
apol requested review of this revision.
REVISION SUMMARY
  It takes into account the dpi of the screen we're rendering to.
  Other overloads assume the window is nullptr and will use the primary screen's dpi which can change almost randomly.
TEST PLAN
  Icons still look fine even if I drag windows from a screen to another.
REPOSITORY
  R242 Plasma Framework (Library)
BRANCH
  master
REVISION DETAIL
  https://phabricator.kde.org/D29102
AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/windowthumbnail.cpp
To: apol, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200422/db793844/attachment.html>
    
    
More information about the Kde-frameworks-devel
mailing list