D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

Friedrich W. H. Kossebau noreply at phabricator.kde.org
Tue Apr 21 17:39:05 BST 2020


kossebau created this revision.
kossebau added reviewers: Frameworks, mart, apol, sitter, bcooksley.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Setting XDG_DATA_DIRS in the ENVIRONMENT property using
  "XDG_DATA_DIRS=/path:$XDG_DATA_DIRS" has two flaws
  
  - the value string is not evaluated e.g. by a shell but set directly, so $XDG_DATA_DIRS will stay verbatim
  - if XDG_DATA_DIRS was not set before, setting it now will trigger the rules to use the default /usr/local/share & /usr/share only if XDG_DATA_DIRS is not set, thus effectively removing these dirs now

REPOSITORY
  R290 KPackage

BRANCH
  fixXDG_DATA_DIRSextending

REVISION DETAIL
  https://phabricator.kde.org/D29063

AFFECTED FILES
  autotests/CMakeLists.txt

To: kossebau, #frameworks, mart, apol, sitter, bcooksley
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200421/6782b10d/attachment.html>


More information about the Kde-frameworks-devel mailing list