D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> plasma-window-management.xml:77
> +      <description summary="notify the client when stacking order changed">
> +        This event will be sent when stacking order changed
> +      </description>

we also need to send it on bind

> plasma-window-management.xml:83
>  
>    <interface name="org_kde_plasma_window" version="10">
>      <description summary="interface to control application windows">

Can we change them all at once.

> plasmawindowmanagement_interface.cpp:167
> +{
> +    wl_array wlIds;
> +

This needs a

wl_resource_get_version(resource) < ORG_KDE_PLASMA_SEND_STACK_SOMETHING_SOMETHING_SINCE_VERSION

A user could be using a flatpak or something with a bundled kwayland that's out of date with kwin. At that point we don't want the client to receive this event or it will explode.

> plasmawindowmanagement_interface.cpp:234
>      }
>  }
>  

We need to send the stacking order here, this way if a client connects and nothing changes, they still have the right order.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D29054

To: bport, zzag, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200421/65792225/attachment-0001.html>