D29036: Print meaningful warning when there is no QGuiApplication

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Apr 21 08:15:23 BST 2020


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  KWindowSystem plug-in loading (and everything regarding a window system, like X or Wayland connection anyway) depends on `QGuiApplication::platformName()` which will be empty when there is none, such as in a `QCoreApplication`.
  This would then just print a meaningless error on how now platform plug-in was found.

TEST PLAN
  - Created a `QCoreApplication`, called `KWindowSystem::windows()`, got a warning that I need a `QGuiApplication` and an empty window list
  - Created a `QGuiApplication`, called `KWindowSystem::windows()`, got no warning and a lost of X window ids
  - Created a `QApplication`, called `KWindowSystem::windows()`, got no warning and a lost of X window ids

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D29036

AFFECTED FILES
  src/pluginwrapper.cpp

To: broulik, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200421/e0908478/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list