D29017: WIP: Introduce three new methods that return all "entries" in a folder
Ahmad Samir
noreply at phabricator.kde.org
Mon Apr 20 18:26:34 BST 2020
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
As was discussed in https://phabricator.kde.org/D28880 with dfaure, it
seems that all users (only two, KWalletManager and Falkon) of the current
read{Entry,Map,Passowrd}list() methods basically use "*" as a wildcard
to get a list of all the "entries" in a folder. Therefore it makes sense
to introduce new methods that do just that, this gets rid of regular
expression usage for matching a certain pattern. This fits with how .e.g.
KWalletManager is using readEntryList(), to get a list of all the entries
to fill a list view with them, then the "matching" is done with a QSFPM-like
class.
TEST PLAN
- make && ctest
- Ported Falkon locally, and it seems to work
REPOSITORY
R311 KWallet
BRANCH
l-kwallet-dump-wildcard (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29017
AFFECTED FILES
CMakeLists.txt
src/api/KWallet/CMakeLists.txt
src/api/KWallet/kwallet.cpp
src/api/KWallet/kwallet.h
src/api/KWallet/org.kde.KWallet.xml
src/runtime/kwalletd/backend/kwalletbackend.cc
src/runtime/kwalletd/backend/kwalletbackend.h
src/runtime/kwalletd/kwalletd.cpp
src/runtime/kwalletd/kwalletd.h
To: ahmadsamir, #frameworks, dfaure
Cc: blaze, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200420/a2d783b8/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list