D28986: API dox: document Q_DECLARE_FLAGS-based flags

David Faure noreply at phabricator.kde.org
Sun Apr 19 18:18:49 BST 2020


dfaure added inline comments.

INLINE COMMENTS

> kjob.h:99
> +    /**
> +     * Stores an OR combination of #Capability values.
> +     */

Inexperienced developers might be confused by the OR in there.
In English it sounds like exclusive or, while the whole point of Q_DECLARE_FLAGS is that multiple flags can be set at the same time.

Why not just say "Stores a combination of" ?

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D28986

To: kossebau, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200419/966b23e7/attachment.html>


More information about the Kde-frameworks-devel mailing list