D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

Aleix Pol Gonzalez noreply at phabricator.kde.org
Sun Apr 19 16:19:47 BST 2020


apol added a comment.


  I wonder, while this will work with all our uses of DropUrlPatterns, this would have been able to work with something like `scheme:/*potato*` which after this patch won't work.
  
  In fact, it's called Patterns, not DropUrlWhenStartsWith. I'd appreciate feedback from someone else. Code-wise, looks better for sure.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28978

To: ahmadsamir, #plasma, apol
Cc: kde-frameworks-devel, plasma-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200419/b73e9364/attachment.html>


More information about the Kde-frameworks-devel mailing list