D28980: Revert "add Baloo DBus signals for moved or removed files"
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Sun Apr 19 14:53:07 BST 2020
bruns created this revision.
bruns added reviewers: Baloo, mgallien, astippich, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
Revert "add missing license"
This reverts commit 96fb5896c304b7292fc3cea87fb584b14b270448 <https://phabricator.kde.org/R293:96fb5896c304b7292fc3cea87fb584b14b270448>.
This reverts commit ef0e268c657718d4a353638f91d3723624c358ac <https://phabricator.kde.org/R293:ef0e268c657718d4a353638f91d3723624c358ac>.
The BalooWatcherApplication DBus interface was created to be used by
Elisa, but the only use there is to create some debug output.
As soon as Elisa registers itself, each rename causes a bunch
of DB queries (in case a directory is renamed, it builds the list
of all children) and a (potentially huge) DBus call.
The DBus interface is totally awkward, as it calls a method in the
watcher application (i.e. replicating the message on the sender side)
instead of using DBus signals and letting the DBus daemon do its job.
Keep the DBus interface as a stub, but remove the caused overhead.
TEST PLAN
ctest
REPOSITORY
R293 Baloo
BRANCH
config_rework
REVISION DETAIL
https://phabricator.kde.org/D28980
AFFECTED FILES
autotests/unit/file/CMakeLists.txt
autotests/unit/file/filewatchtest.cpp
autotests/unit/file/metadatamovertest.cpp
autotests/unit/file/metadatamovertest.h
src/engine/transaction.cpp
src/engine/transaction.h
src/file/CMakeLists.txt
src/file/filewatch.cpp
src/file/filewatch.h
src/file/mainhub.cpp
src/file/mainhub.h
src/file/metadatamover.cpp
src/file/metadatamover.h
To: bruns, #baloo, mgallien, astippich, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200419/146239dc/attachment.html>
More information about the Kde-frameworks-devel
mailing list