D28974: [KFontChooser] Make styleIdentifier() more precise by adding font styleName

[Ahmad Samir]

ahmadsamir added a comment.


  This particular one is the same bug, we've been fixing it for a couple of months now; in KConfig, in the Fonts KCM/KFontChooser*, we even had to bring KFontDialog back from the deprecation pile in KDELibs4Support (for this and for decimal font sizes which QFontDialog doesn't allow) all that because upstream most likely won't take a patch that clears a font styleName property when it's weight is Normal and the style name is Regular|Normal|Book|Roman... I don't claim to understand their reasons (I keep finding new reasons as I look at it more) but sometimes technical-correctness isn't that "correct".

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-tightenStyleId (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28974

To: ahmadsamir, #frameworks, dfaure, cfeck, bport
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200419/ef610366/attachment.html>