D28964: [KRichTextWidget] Remove ancient workaround and fix regression (commit 1d1eb6f)

[Igor Poboiko]

poboiko created this revision.
poboiko added reviewers: Frameworks, dfaure, ahmadsamir.
Herald added a project: Frameworks.
poboiko requested review of this revision.

REVISION SUMMARY
  This patch removes the workaround, which (according to comment) comes from Qt4
  times. Although I wasn't even able to find the original bug (only the title,
  "Remove implicit margin on bullet lists when exporting to HTML"), it would seem
  like the workaround is no longer actual (i.e. margins are consistent).
  
  This is an alternative approach to D28819: [KRichTextEdit] Always treat key press as single modification in undo stack <https://phabricator.kde.org/D28819>, as it removes the code which
  actually cluttered the undo stack. The latter patch introduced couple
  regressions unfortunately
  (e.g. ability to "undo" a written word, not just the last letter)
  
  However, it slightly changes the behavior: it removes margins around a bullet
  list, which are probably not needed anyways (e.g. LibreOffice doesn't have it)

TEST PLAN
  1. Create a bullet list in `krichtexteditor` with couple of lines
  2. Try to undo -> a single undo is sufficient
  3. Press enter to add bunch of empty new lines, so that scroll appears
  4. Scroll still follows the cursor

REPOSITORY
  R310 KTextWidgets

BRANCH
  remove-workaround (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28964

AFFECTED FILES
  src/widgets/krichtextedit.cpp
  src/widgets/nestedlisthelper.cpp
  src/widgets/nestedlisthelper_p.h

To: poboiko, #frameworks, dfaure, ahmadsamir
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200418/d65bffc1/attachment.html>