D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

[Méven Car]

meven accepted this revision.
meven added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> dfaure wrote in global.h:323
> There are bugs in the current kio_file implementation if StatBasic isn't set.
> 
>   mode_t type = 0;
>   if (details & KIO::StatBasic) {
>       ... code that sets type ...
>   }
>   if (details & KIO::StatAcl) {
>       appendACLAtoms(targetPath, entry, type); // oops type is 0
>   }
> 
> Hmm I thought I saw more, but now I don't see more (must have been fixed meanwhile). If you fix the bug I'm happy to remove the comment, LOL.

I believe it was `StatResolveSymlink`
D28947 <https://phabricator.kde.org/D28947> for the StatAcl fix

REPOSITORY
  R241 KIO

BRANCH
  2020_optimize_recursive_size

REVISION DETAIL
  https://phabricator.kde.org/D28901

To: dfaure, meven, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200418/81966527/attachment-0001.html>