D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

[Igor Poboiko]

poboiko added a comment.


  In D28819#651007 <https://phabricator.kde.org/D28819#651007>, @dfaure wrote:
  
  > The *ideal* way of proceeding is to submit a Qt bug report with your testcase (after searching for an existing Qt bug report for the same issue), then turn it into a Qt autotest and make a gerrit merge request for Qt with both the test and a fix for it. And then, and only then, add a workaround in krichtextedit with a Qt version ifdef and a reference to the Qt bug report.
  >
  > The less ideal way is to only do the Qt bug report and the workaround here...
  
  
  Thanks for your comment! 
  I already did the first part (that is, Qt bugreport <https://bugreports.qt.io/browse/QTBUG-83605>).
  I can play around Qt code too, and see if I can prepare a test & patch.
  Although, to be honest, I'm a bit afraid to touch it. Most likely there was some reasoning behind this "dirty" value, which I can't yet guess by looking at the code (it lacks documentation / comments) :(

REPOSITORY
  R310 KTextWidgets

REVISION DETAIL
  https://phabricator.kde.org/D28819

To: poboiko, #frameworks, mlaurent, dfaure
Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200418/2245d19b/attachment-0001.html>