D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69
Ahmad Samir
noreply at phabricator.kde.org
Fri Apr 17 11:49:29 BST 2020
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, nicolasfella.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
Use new KBookMarkMenu ctor that doesn't take a KActionCollection parameter;
AFAICS there's no need to add the KBookMarkMenu actions to the actionCollection
here because there's no shortcuts editor dialog for KFileDialog/Widget.
Remove an old comment from kfilebookmarkhandler_p.h, it has been tested
and it seems to work.
TEST PLAN
- make && ctest
- The bookmarks menu in the KDE open file dialog still works
REPOSITORY
R241 KIO
BRANCH
l-kbookmark (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28910
AFFECTED FILES
src/filewidgets/kfilebookmarkhandler.cpp
src/filewidgets/kfilebookmarkhandler_p.h
To: ahmadsamir, #frameworks, dfaure, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200417/8daf7a22/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list