D28883: Add wrapper for wl_global_remove
David Edmundson
noreply at phabricator.kde.org
Thu Apr 16 15:38:07 BST 2020
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
Removes the Global from the registry, but does not delete the underlying
wl_global
Removal of a global is racey in wayland.
A client could be trying to bind at that moment.
Typically globals are static for the lifespan of the compositor, however
there are exceptions
For those cases this call will can remove the global from the registry,
but still keep the wl_global instance alive
and handling bind requests.
The compositor can then remove the Global wrapper (this object) deleting
the wl_global after an arbitrary delay or
keep it around for re-use for the duration of the compositor.
TEST PLAN
Unit test
Made blur global outlive BlurEffect - no longer disconnects plasma on config changes
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28883
AFFECTED FILES
autotests/client/test_wayland_blur.cpp
src/server/global.cpp
src/server/global.h
To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200416/e5183362/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list