D28856: Save disabling of desktop file components in kglobalshortcutsrc

David Redondo noreply at phabricator.kde.org
Wed Apr 15 16:23:00 BST 2020


davidre added inline comments.

INLINE COMMENTS

> globalshortcutsregistry.cpp:274
> +    auto disabledComponents = KConfigGroup(&_config, "disabledComponents").readEntry("disabled", QStringList());
>      for (const QString &groupName : groupList)
>          {

good point

> globalshortcutsregistry.cpp:333
>              for (const QString &desktopFile : lstDesktopFiles) {
> -                if (_components.contains(desktopFile)) {
> +                if (_components.contains(desktopFile) || disabledComponents.contains(desktopFile)) {
>                      continue;

It actually is if you follow the constructor chain

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D28856

To: davidre, davidedmundson, fvogt, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200415/5b1cde3f/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list