D28811: Add drawer on mobile and clean code

Carl Schwan noreply at phabricator.kde.org
Wed Apr 15 10:20:04 BST 2020


ognarb planned changes to this revision.
ognarb added a comment.


  In D28811#648700 <https://phabricator.kde.org/D28811#648700>, @ochurlaud wrote:
  
  > I really dislike how you close brackets in css : it's more dense and harder to read.
  >
  > You indent sometimes with 1,2 or 3 spaces: it should be consistent.
  >
  > Is it something common to have css declaration within others? It's the first time I see that, so I'm confused.
  
  
  The css code is generated from the new scss file. I didn't remove the generated CSS code because I didn't want to add sass as a dependency of kapidox. I will add this information to the doc.
  
  The command to generate the css code is:
  
    sass src/kapidox/data/htmlresource/css/kapidox.scss src/kapidox/data/htmlresource/css/kapidox.css
  
  Maybe this file can be moved later to `websites/aether-sass` so that the layout with the sidebar can be shared with `websites/aether-sphinx` and `websites/aether-mediawiki` and hosted in the KDE cdn.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28811

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200415/39812cc7/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list