D20655: Use generated DBus interface
David Edmundson
noreply at phabricator.kde.org
Tue Apr 14 11:26:31 BST 2020
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
We copy udisks xml already. I don't think it ends up any better. Otherwise we have a compile time dep on a runtime plugin, which inevitably means we need to make it optional which only introduces more real-world bugs. It also means future devs know what we were compiled against.
Marking as requesting changes for the extra include, but personally I think it's generally good to go.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D20655
To: broulik, #frameworks, davidedmundson, bruns
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200414/f3fac183/attachment.html>
More information about the Kde-frameworks-devel
mailing list