D24773: kio_trash: Add size, modification, access and create date for trash:/

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> dfaure wrote in trashsizecache.cpp:131
> Interesting. One benefit of lambdas is that they can work on local variable; I would have captured max_mtime by reference and modified it inside the lambda.
> Written this way (which I guess more "pure functional programming" because no side effects), it could be a static helper function ;)
> 
> Wait, this doesn't work, does it? It makes a copy of mtime right now, while it's still 0.
> 
> I'm pretty sure you want to capture by [&] instead
> (and then, unless you insist on pure functions, I'd suggest just modifying it here, and returning void). It removes the "max_mtime = " duplication ;)

It probably didn't work, thanks

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24773

To: meven, #frameworks, ngraham, elvisangelaccio, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200413/95826a79/attachment.html>