D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

[Ahmad Samir]

ahmadsamir added inline comments.

INLINE COMMENTS

> dfaure wrote in kfontrequester.cpp:188
> It's really not obvious from the above that this modifies m_selFont.
> 
> But I see QFont has no isValid() so we can't adopt an API like QColorDialog::getColor (plus KFontChooserDialog has been released now).
> 
> Oh well.

Plus we can't end up with a non-valid QFont, the dialog is filled from QFontDataBase; so unless the user went and uninstalled the font while the dialog was open, it should be OK. Also, font substitution will take care of a font-gone-MIA (I am sure of that on Linux, and most likely other OS's have similar solutions).

I was curious so I looked at QColorDialog::getColor() and it looks like they changed it (or you meant getRgba?).

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D28774

To: ahmadsamir, #frameworks, dfaure, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200413/02be05e6/attachment-0001.html>