D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

[David Faure]

dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kfontrequester.cpp:188
> +
> +    const int result = KFontChooserDialog::getFont(m_selFont, flags, q->parentWidget());
>  

It's really not obvious from the above that this modifies m_selFont.

But I see QFont has no isValid() so we can't adopt an API like QColorDialog::getColor (plus KFontChooserDialog has been released now).

Oh well.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  l-kfontreq (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28774

To: ahmadsamir, #frameworks, dfaure, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200413/74ef3e54/attachment-0001.html>