D28745: Skipping catching of thumbnails on encrypted filesystems

[Ivan Čukić]

ivan requested changes to this revision.
ivan added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> thumbnail.cpp:730
> +            const auto thumbRootMount = mountsList.findByPath(thumbRoot);
> +            std::copy_if(mountsList.begin(), mountsList.end(),
> +                 std::back_inserter(encryptedMountsList),

Seems suboptimal to copy all the items just to be able to check whether ant of them satisfy a requirement - `std::any_of` could be an alternative.

Or, possibly even better, `mountsList.findByPath(...)` and then check the filesystem type.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin
Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200413/09d710d0/attachment-0001.html>