D28780: [FstabWatcher] Fix loosing of fstab watcher

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sun Apr 12 21:59:31 BST 2020


bruns added inline comments.

INLINE COMMENTS

> apol wrote in fstabwatcher.cpp:110
> Use m_isFstabWatched? Or maybe m_isFstabWatched isn't necessary altogether and we can check in other places too.

No. QFileSystemWatcher looses the watch when the file is deleted/renamed, so m_isFstabWatched may be (still) true when contains() returns false.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28780

To: bruns, #frameworks
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200412/d72edbda/attachment.html>


More information about the Kde-frameworks-devel mailing list