D28782: [Fstab] Do not emit deviceAdded twice on fstab/mtab changes

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Frameworks, afiestas.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The deviceAdded signal was emitted twice, once with the old device list
  in m_deviceList, once with the new one.
  
  The first one is actually wrong and was fixed in kdelibs4 by moving the
  deviceAdded signal after the m_deviceList update. In KF5, the second
  signal was added but the first one never removed.
  
  Move the m_deviceList update to the top (though for deviceRemoved it
  does not matter much), and remove the second signal.
  
  Depends on D28779 <https://phabricator.kde.org/D28779>

TEST PLAN
  1. solid-hardware listen
  2. add an entry to the fstab
  
  -> deviceAdded is only emitted once

REPOSITORY
  R245 Solid

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28782

AFFECTED FILES
  src/solid/devices/backends/fstab/fstabmanager.cpp

To: bruns, #frameworks, afiestas
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200412/d38a0fdd/attachment.html>