D28776: FstabDevice: Avoid recurrent construction of emblems QStringList
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Sun Apr 12 19:13:40 BST 2020
bruns created this revision.
bruns added a reviewer: Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
emblems can return exactly two different values. Construct the two
possible values statically, so these can be shared by all FstabDevice
instances.
TEST PLAN
correct emblems are still shown
REPOSITORY
R245 Solid
BRANCH
submit
REVISION DETAIL
https://phabricator.kde.org/D28776
AFFECTED FILES
src/solid/devices/backends/fstab/fstabdevice.cpp
To: bruns, #frameworks
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200412/ad444ddb/attachment.html>
More information about the Kde-frameworks-devel
mailing list