D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> fstabdevice.cpp:63
>      }
>  
> +    if (m_storageType == StorageType::NetworkShare) {

the `if (m_displayName.isEmpty())` block belongs here

> fstabdevice.cpp:145
> +    }
> +    const auto filePath = m_storageAccess->filePath();
> +    if (!filePath.isEmpty()) {

use `FstabHandling::mountPoints(m_device).first()` instead of m_storageAccess.

> fstabdevice.h:64
>      QString m_vendor;
> +    QString m_label;
>      QString m_description;

Wrong variable name

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200412/fc2aae1a/attachment.html>