D27152: Introduce FilesystemEntry class

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> hallas wrote in fstabhandling.cpp:374
> No problem, I really appreciate the thorough review feedback you provide. I definitely prefer to take more time and get things right, then to rush things and potentially get them wrong.
> 
> So, have you had a chance to test out the patch? Do you think it is ready to land?
> 
> I will also start to prepare the next patch as part of splitting up the mega-refactor patch from D26600 <https://phabricator.kde.org/D26600>

The `id()` method and members are still part of the FstabEntry, where they do not belong.

The UDIs go through some further mangling in `FstabHandling::deviceList()`, which should be covered by the unit-tests as well.

Conceptually, the `_k_deviceNameForMountpoint`/`_k_deviceNameForFilesystemEntry` should be part of the m_mtabCache/m_fstabCache class (which currently is just a `QMultiHash<>`). This class can then be unit tested easily.

For now, keep the `_k_deviceNameForMountpoint` inside fstabhandling.cpp

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D27152

To: hallas, #frameworks, bruns, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200412/7a303c12/attachment.html>