D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS
David Faure
noreply at phabricator.kde.org
Sat Apr 11 18:50:21 BST 2020
dfaure created this revision.
dfaure added reviewers: apol, broulik, davidedmundson, kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.
REVISION SUMMARY
I had every toplevel entry doubled in kontact's configuration dialog
due to $XDG_DATA_DIRS=<myPrefix>/share:/usr/share
which led to parsing both
<myPrefix>/share/kontact/ksettingsdialog/knotes.setdlg
and
/usr/share/kontact/ksettingsdialog/knotes.setdlg
Solution: do this in two steps (collect names, then look up each name to
only the most local variant of it). This was more natural with
KStandardDirs API, I admit.
REPOSITORY
R295 KCMUtils
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D28760
AFFECTED FILES
src/ksettings/dialog.cpp
To: dfaure, apol, broulik, davidedmundson, kossebau
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200411/73044ca0/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list