D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

[Ahmad Samir]

ahmadsamir added a comment.


  I did some more testing:
  
    $ grep -ir :local *protocol
    about.protocol:Class=:local
    activities.protocol:Class=:local
    applications.protocol:Class=:local
    ar.protocol:Class=:local
    baloosearch.protocol:Class=:local
    bookmarks.protocol:Class=:local
    camera.protocol:Class=:local
    desktop.protocol:Class=:local
    filenamesearch.protocol:Class=:local
    fonts.protocol:Class=:local
    info.protocol:Class=:local
    man.protocol:Class=:local
    programs.protocol:Class=:local
    recentdocuments.protocol:Class=:local
    settings.protocol:Class=:local
    tags.protocol:Class=:local
    tar.protocol:Class=:local
    timeline.protocol:Class=:local
    zip.protocol:Class=:local
  
    $ grep -ir writ *protocol
    activities.protocol:writing=true
    applications.protocol:writing=false
    baloosearch.protocol:writing=false
    camera.protocol:writing=false
    cifs.protocol:writing=true
    desktop.protocol:writing=true
    filenamesearch.protocol:writing=false
    fish.protocol:writing=true
    fonts.protocol:writing=true
    ldap.protocol:writing=true
    ldaps.protocol:writing=true
    metainfo.protocol:writing=true
    mmst.protocol:writing=false
    mmsu.protocol:writing=false
    mtp.protocol:writing=true
    pnm.protocol:writing=false
    programs.protocol:writing=false
    recentdocuments.protocol:writing=true
    rtsp.protocol:writing=false
    rtspt.protocol:writing=false
    rtspu.protocol:writing=false
    settings.protocol:writing=false
    sftp.protocol:writing=true
    smb.protocol:writing=true
    tags.protocol:writing=true
    timeline.protocol:writing=true
  
  from all these, I would enable changing icon for KItemFile.isLocalFile(), desktop:/ and recentdocuments:/; I couldn't test the camera:/ protocol as I don't currently have access to a camera.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28679

To: ahmadsamir, #frameworks, dfaure, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200410/3cc183a3/attachment.html>