D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

[Méven Car]

meven added a comment.


  The test is not stable (I reproduce locally)
  
  https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/34/testReport/junit/projectroot/autotests/kiocore_jobtest/
  
    ==7022==ERROR: AddressSanitizer: heap-use-after-free on address 0x610000099be8 at pc 0x7f09559df9ed bp 0x7fff81ec0fe0 sp 0x7fff81ec0fd8
    READ of size 8 at 0x610000099be8 thread T0
        #0 0x7f09559df9ec in QSharedDataPointer<KIO::UDSEntryPrivate>::operator->() const /usr/include/qt5/QtCore/qshareddata.h:82
        #1 0x7f09559d499a in KIO::UDSEntry::numberValue(unsigned int, long long) const /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.14/src/core/udsentry.cpp:368
        #2 0x455940 in JobTest::statWithInode() /home/jenkins/workspace/Frameworks/kio/kf5-qt5 SUSEQt5.14/autotests/jobtest.cpp:1534
  
  Replacing line 1517
  
    const KIO::UDSEntry &entry = job->statResult();
  
  by
  
    const KIO::UDSEntry entry = job->statResult();
  
  Fixes the issue, but I don't exactly see why.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28478

To: ahmadsamir, #frameworks, dfaure, meven, bruns
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200409/4d15df90/attachment.html>