D28682: export done signal in filecontentindexer

[Alexander Stippich]

astippich added a comment.


  > Quoted Text
  > 
  >> ! In D28682#644412 <https://phabricator.kde.org/D28682#644412>, @mgallien wrote:
  > 
  > This is the reason why it is so slow in Elisa?
  
  Do you mean slow for picking up changes in files? Then yes. This happens when a track is modified when Elisa is running and listens for finishedIndexingFile signal. It then immediately queries baloo database, which still has the old values.
  Only after the done signal the transaction to baloo's database is complete.
  
  In D28682#644414 <https://phabricator.kde.org/D28682#644414>, @bruns wrote:
  
  > In general fine for me.
  >
  > How will Elisa deal with the indexer maybe crashing inbetween? Do we also need a signal for a batch start?
  
  
  From my (limited) understanding, the finishedIndexingFile will no be emitted when an indexers crashes, does it? Then I think it is fine without an additional signal as long as the done() signal is still emitted as it is possible to reset the applications' internal list. Or will it retry some files of the current batch?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28682

To: astippich, #baloo, bruns
Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200408/02d23a70/attachment-0001.html>