D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

[Ahmad Samir]

ahmadsamir added a comment.


  I thought about that, but since I am not experienced with network mounts (I rarely use them), I didn't expand the test
  
  In D28679#644274 <https://phabricator.kde.org/D28679#644274>, @sitter wrote:
  
  > Looks reasonable. Though... Shouldn't that rather be any protocol that isn't `file`? Or at least all that are remote? (assuming we have a way of telling which slaves are remote)
  >
  > If I open sftp it also shows no dir icons yet lets me set one.
  
  
  I thought about that, but since I am not experienced with network mounts (I rarely use them), I didn't venture that way.
  
  About checking, KFileItem has an isLocalFile() method.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28679

To: ahmadsamir, #frameworks, dfaure, sitter
Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200408/95cef768/attachment.html>