D28592: [ApplicationLauncherJob] Guard against m_pids being empty

David Faure noreply at phabricator.kde.org
Sun Apr 5 17:57:02 BST 2020


dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  This, hmm, sounds wrong. Is the caller calling pid() even though the job finished with an error code? Ah, yes, indeed, in the case of KRun. Whoops.
  
  Here's my suggested fix instead: D28598 <https://phabricator.kde.org/D28598>

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28592

To: ahmadsamir, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200405/8b04606f/attachment.html>


More information about the Kde-frameworks-devel mailing list