D26113: Places: For mounted volume display mount points instead of description

Méven Car noreply at phabricator.kde.org
Sun Apr 5 12:20:16 BST 2020


meven added a comment.


  In D26113#642028 <https://phabricator.kde.org/D26113#642028>, @bruns wrote:
  
  > I say its the responsibility of Vaults to set the option. For Vaults, there is no fstab anyway, just an options value in the mtab at runtime.
  
  
  My primary concern is for network shares.
  The vault issue is a distinct bug than the one I am meaning to fix here.
  
  > If you want to display more info in the tooltip, probably start with `StorageAccess.filePath`.
  
  The point of this diff is to use the filePath by default as **label**, which is way more explicit than the description "/export on 192.168.0.10" for network shares for instance, while not breaking the x-gvfs-name case (which the state of this patch currently does not respect)
  All you are saying is not contradicting my suggestion in https://phabricator.kde.org/D26113#641998
  So I feel this conversation is sterile, and I should go ahead with it in solid and loop back here once it is done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26113

To: meven, #frameworks, ngraham
Cc: feverfew, bruns, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20200405/a1bcb34a/attachment-0001.html>


More information about the Kde-frameworks-devel mailing list